Comments on: ASP.NET MVC Controller Best Practices – Skinny Controllers http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/ Jag Reehal on Agile Development, ASP.NET MVC, Silverlight and all manner of good stuff Sun, 25 Jul 2010 19:27:22 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Neil Kerkin http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/comment-page-1/#comment-30 Neil Kerkin Mon, 26 Oct 2009 16:33:39 +0000 http://www.arrangeactassert.com/?p=285#comment-30 Hi Jag, my point is that if someone follows your current approach they only get a few of the benefits of skinny controllers e.g. SoC and simplified tests(which you haven't show for GetAnimals). You specifically mention Paging and DRY but this logic will be repeated in every IService class. Hence duplicate logic and tests. Effectively you haven't removed the smell, just moved it to another layer. Don't get me wrong, i think this is a good article. Just needs that extra step to show the full benefits of skinny controllers. Maybe a follow-up post? Hi Jag,
my point is that if someone follows your current approach they only get a few of the benefits of skinny controllers e.g. SoC and simplified tests(which you haven’t show for GetAnimals).

You specifically mention Paging and DRY but this logic will be repeated in every IService class. Hence duplicate logic and tests.

Effectively you haven’t removed the smell, just moved it to another layer.

Don’t get me wrong, i think this is a good article. Just needs that extra step to show the full benefits of skinny controllers.

Maybe a follow-up post?

]]> By: Jag Reehal http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/comment-page-1/#comment-23 Jag Reehal Wed, 14 Oct 2009 20:12:32 +0000 http://www.arrangeactassert.com/?p=285#comment-23 Hi Neil thanks for the comment. I agree that in a real world ASP.NET MVC website you should abstract the paging logic so you don’t end up repeating yourself. The aim of the post is to show why you should keep your controllers skinny and how you could go about refactoring a fat controller. Any further refactoring would take the focus away from this. Hi Neil thanks for the comment.

I agree that in a real world ASP.NET MVC website you should abstract the paging logic so you don’t end up repeating yourself.

The aim of the post is to show why you should keep your controllers skinny and how you could go about refactoring a fat controller. Any further refactoring would take the focus away from this.

]]> By: Neil Kerkin http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/comment-page-1/#comment-22 Neil Kerkin Wed, 14 Oct 2009 18:01:54 +0000 http://www.arrangeactassert.com/?p=285#comment-22 I'm all for skinny controllers (http://stackoverflow.com/questions/975680/asp-net-mvc-actions-separation-of-concerns-single-responsibility-principle) but you haven't removed any complexity from your application. i.e. you now have to test repeated logic (paging) in each of your services rather than on your controllers. Why not show one further refactoring and abstract out the paging logic e.g. PagedList? I understand this isn't a "How to implement paging" article but i feel it would improve the example. I’m all for skinny controllers (http://stackoverflow.com/questions/975680/asp-net-mvc-actions-separation-of-concerns-single-responsibility-principle) but you haven’t removed any complexity from your application. i.e. you now have to test repeated logic (paging) in each of your services rather than on your controllers.

Why not show one further refactoring and abstract out the paging logic e.g. PagedList? I understand this isn’t a “How to implement paging” article but i feel it would improve the example.

]]> By: Bob Cravens http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/comment-page-1/#comment-17 Bob Cravens Sat, 26 Sep 2009 20:59:17 +0000 http://www.arrangeactassert.com/?p=285#comment-17 Thanks for refactoring the data access details out of the controller. Although LINQ to SQL / Entity Framework makes our lives easy, it is often overused in controllers (presentation layer). It is too easy to use .skip / .take for paging in the controller. This has maintainability issues. Much better to have the LINQ code refactored into a service (like you have presented). Thanks for refactoring the data access details out of the controller. Although LINQ to SQL / Entity Framework makes our lives easy, it is often overused in controllers (presentation layer). It is too easy to use .skip / .take for paging in the controller. This has maintainability issues. Much better to have the LINQ code refactored into a service (like you have presented).

]]> By: marcdormey http://www.arrangeactassert.com/asp-net-mvc-controller-best-practices-%e2%80%93-skinny-controllers/comment-page-1/#comment-16 marcdormey Fri, 25 Sep 2009 14:08:28 +0000 http://www.arrangeactassert.com/?p=285#comment-16 This is a perfect example of "Command/Query Separation". 1. Find a domain entity 2. Execute one method on that entity 3. Commit the transaction Keeps the controller and presentation clean. Read more http://dylanbeattie.blogspot.com/2009/09/altnet-beers-commandquery-separation.html This is a perfect example of “Command/Query Separation”.

1. Find a domain entity
2. Execute one method on that entity
3. Commit the transaction

Keeps the controller and presentation clean.
Read more http://dylanbeattie.blogspot.com/2009/09/altnet-beers-commandquery-separation.html

]]>